refactor(network): drop chain-id reachability probe from obol network status#391
Closed
OisinKyne wants to merge 1 commit intooisin/377-1from
Closed
refactor(network): drop chain-id reachability probe from obol network status#391OisinKyne wants to merge 1 commit intooisin/377-1from
obol network status#391OisinKyne wants to merge 1 commit intooisin/377-1from
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probe (introduced via #388) was sold as detecting "stale custom RPC
pins from a previous test run", but the symptom it was built to chase
— eRPC returning ERC721NonexistentToken on a freshly-minted agent ID
— was actually read-side staleness in eRPC, not a stale Anvil fork.
PR #387's
Client.WaitForAgentis the correct fix and is alreadywired into the CLI register paths.
eth_chainId is also a poor liveness probe: it can't catch lagging
upstreams, and an Anvil fork of base-sepolia returns the same chain
id (84532) as the real chain — exactly the case it was built to
detect.
eRPC already tracks per-upstream health metrics; if we want a future
obol network statusreachability column it should parse those, notredo the work badly in-process.
Changes:
renderUpstreamProbes, uiPrinter, and the
timeimport.flow-02 and flow-05 still pass: they grep
eRPC|Pod|Upstreamheaderswhich remain in the output.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com